Xray integration test #113
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Please refactor with this naming convention instead
| @@ -429,4 +461,26 @@ private static class GrammarParseException extends RuntimeException { | |||
| + "%nSee the below error message for more details", originalSource, title), e); | |||
| } | |||
| } | |||
|
|
|||
| public interface PickleJarFactoryGenerator extends QuadFunction<PdslGherkinRecognizer, | |||
There was a problem hiding this comment.
I don't think we're actually using this or the QuadFunction anywhere. Can you delete them if this is the case?
There was a problem hiding this comment.
removed
| @@ -57,19 +57,19 @@ public DefaultPdslTestCase(String testCaseTitle, List<TestBodyFragment> testBody | |||
| } | |||
|
|
|||
| @Override | |||
| public URI getOriginalSource() { return source; } | |||
There was a problem hiding this comment.
These are not backwards compatible changes!
If you modify a public API someone else may break someone else's code!
There was a problem hiding this comment.
it automatically comes up.. i didn't do this change
| import java.util.Properties; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class XrayAuth { |
There was a problem hiding this comment.
XRay doesn't belong in the standard library!
There was a problem hiding this comment.
moved
| private final String clientId; | ||
| private final String clientSecret; | ||
|
|
||
| public XrayAuth(String xrayUrl, String clientId, String clientSecret) { |
There was a problem hiding this comment.
You need Javadocs on all public classes and methods
There was a problem hiding this comment.
added javadocs
| import java.util.Iterator; | ||
| import java.util.List; | ||
|
|
||
| public record XrayTestCase(URI originalSource, List<String> unfilteredPhraseBody, |
There was a problem hiding this comment.
Javadocs, no XRay classes in standard library
There was a problem hiding this comment.
moved
src/main/resources/xray.properties
Outdated
There was a problem hiding this comment.
Get rid of XRay properties in the standard library.
Also....
WHAT THE HECK WERE YOU THINKING PUTTING SECRETS IN A PUBLIC SPACE!!!! PULL IT DOWN! PULL IT DOWN!!!!!!!!!!
There was a problem hiding this comment.
removed
There was a problem hiding this comment.
This looks like a test specifically for XRay. It's not suitable for the standard library.
There was a problem hiding this comment.
removed
There was a problem hiding this comment.
moved
There was a problem hiding this comment.
Remove your backups from all of your CLs.
There was a problem hiding this comment.
removed
No description provided.