-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new method to validate schema that throws #77
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,14 @@ public WatchFaceXmlValidator() { | |
resourceManager = new ResourceManager(); | ||
} | ||
|
||
/** Exception thrown when the watch face format validation has failed to execute. */ | ||
public static class WatchFaceFormatValidationException extends Exception { | ||
public WatchFaceFormatValidationException(String message, Throwable cause) { | ||
super(message, cause); | ||
} | ||
|
||
} | ||
|
||
/** | ||
* Check whether the validator support the version or not | ||
* | ||
|
@@ -75,11 +83,11 @@ public boolean validate(String xmlPath, String version) { | |
return true; | ||
} catch (SAXParseException e) { | ||
String errorMessage = String.format( | ||
"[Line %d:Column %d]: %s", | ||
e.getLineNumber(), | ||
e.getColumnNumber(), | ||
e.getMessage() | ||
); | ||
"[Line %d:Column %d]: %s", | ||
e.getLineNumber(), | ||
e.getColumnNumber(), | ||
e.getMessage() | ||
); | ||
Log.e(errorMessage); | ||
return false; | ||
} catch (Exception e) { | ||
|
@@ -100,6 +108,7 @@ public boolean validate(Document xmlDocument, String version) { | |
if (!isSupportedVersion(version)) { | ||
throw new RuntimeException("Validator not support the version #" + version); | ||
} | ||
|
||
validateXMLSchema( | ||
resourceManager.getXsdFile(version).getCanonicalPath(), new DOMSource(xmlDocument)); | ||
return true; | ||
|
@@ -109,8 +118,37 @@ public boolean validate(Document xmlDocument, String version) { | |
} | ||
} | ||
|
||
/** | ||
* Validate watch face format xml via specified version of the watch face xsd file. | ||
* | ||
* @param xmlDocument the watchface layout document | ||
* @param version version of the watch face format | ||
* @return true if valid, else false | ||
* @throws WatchFaceFormatValidationException if the schema for the validation was not | ||
* available. | ||
*/ | ||
public boolean validateOrThrow(Document xmlDocument, String version) | ||
throws WatchFaceFormatValidationException { | ||
if (!isSupportedVersion(version)) { | ||
Log.e("Validator not support the version #" + version); | ||
return false; | ||
} | ||
|
||
try { | ||
validateXMLSchema( | ||
resourceManager.getXsdFile(version).getCanonicalPath(), new DOMSource(xmlDocument)); | ||
return true; | ||
} catch (SAXException | IOException e) { | ||
Log.e(e.getMessage()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Log.e("Could not validate xml", e); There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
return false; | ||
} catch (IllegalArgumentException e) { | ||
throw new WatchFaceFormatValidationException("No schema available: " + e.getMessage(), e); | ||
} | ||
} | ||
|
||
|
||
private static void validateXMLSchema(String xsdPath, Source xmlSource) throws | ||
IllegalArgumentException, SAXException, IOException, NullPointerException { | ||
IllegalArgumentException, SAXException, IOException, NullPointerException { | ||
// https://stackoverflow.com/questions/20807066/how-to-validate-xml-against-xsd-1-1-in-java | ||
SchemaFactory factory = SchemaFactory.newInstance("http://www.w3.org/XML/XMLSchema/v1.1"); | ||
Schema schema = factory.newSchema(new File(xsdPath)); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log.e("Validator does not support version #" + version);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done