Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit flush and close before os.rename to fix EOFError: Ran out of input #1263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anmyachev
Copy link

Even with this fix: #1243 EOFError: Ran out of input error is observed when using yapf with pre-commit on powerful multi-core systems.

Before I suggest this change to you, I tested it in our repository using a fork: intel/intel-xpu-backend-for-triton#3324. For 5 days now I have not seen the error again, which gives me confidence to say that the change at least reduces the frequency of this problem, and at most solves it completely.

Hi @bwendling, could you review this change?

Copy link

google-cla bot commented Feb 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@anmyachev
Copy link
Author

Hi @bwendling!

EOFError: Ran out of input error has not been observed for 2 weeks now (with this fix). Friendly reminder to review.

Hi @hartwork, maybe you can review too.

@alexkau
Copy link

alexkau commented Feb 25, 2025

My team recently had to upgrade yapf to get python 3.13 compatibility, and we're now seeing this issue once or twice per week. We aren't using especially high-end build nodes (16 cpu, 32GB RAM), and we're not an especially large team. We're going to try switching to the forked version with this fix, but it seems like this issue might be widespread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants