update documentation for acceptable MDS token parmeter combinations. (#…

…1704)
googleapis · Mar 11, 2025 · c78065c · c78065c
1 parent 102c171
commit c78065c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 20 deletions.
diff --git a/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java b/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
@@ -118,10 +118,9 @@ public class ComputeEngineCredentials extends GoogleCredentials
    *
    * <p>Behavior of setting {@link GoogleAuthTransport} / {@link BindingEnforcement}:
    *
-   * <p>MTLS-bound token where binding enforcement depends on IAM policy: MTLS / {}, {} /
-   * IAM_POLICY, MTLS / IAM_POLICY
+   * <p>MTLS-bound token where binding enforcement depends on IAM policy: MTLS / IAM_POLICY
    *
-   * <p>MTLS-bound token where bindings are always enforced: {} / ON, MTLS / ON
+   * <p>MTLS-bound token where bindings are always enforced: MTLS / ON
    *
    * <p>DirectPath bound token: ALTS / {}
    */

diff --git a/oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java b/oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java
@@ -200,9 +200,9 @@ public void buildTokenUrl_nullTransport() {
             .setGoogleAuthTransport(null)
             .setBindingEnforcement(ComputeEngineCredentials.BindingEnforcement.ON)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String tokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?binding-enforcement=on", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?binding-enforcement=on", tokenUrl);
   }
 
   @Test
@@ -212,9 +212,9 @@ public void buildTokenUrl_nullBindingEnforcement() {
             .setGoogleAuthTransport(ComputeEngineCredentials.GoogleAuthTransport.MTLS)
             .setBindingEnforcement(null)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String tokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?transport=mtls", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?transport=mtls", tokenUrl);
   }
 
   @Test
@@ -230,25 +230,25 @@ public void buildTokenUrl_nullTransport_nullBindingEnforcement() {
   }
 
   @Test
-  public void buildTokenUrlSoftMtlsBound_mtls_transport() {
+  public void buildTokenUrl_mtls_transport() {
     ComputeEngineCredentials credentials =
         ComputeEngineCredentials.newBuilder()
             .setGoogleAuthTransport(ComputeEngineCredentials.GoogleAuthTransport.MTLS)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String tokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?transport=mtls", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?transport=mtls", tokenUrl);
   }
 
   @Test
-  public void buildTokenUrlSoftMtlsBound_iam_enforcement() {
+  public void buildTokenUrl_iam_enforcement() {
     ComputeEngineCredentials credentials =
         ComputeEngineCredentials.newBuilder()
             .setBindingEnforcement(ComputeEngineCredentials.BindingEnforcement.IAM_POLICY)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String tokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?binding-enforcement=iam-policy", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?binding-enforcement=iam-policy", tokenUrl);
   }
 
   @Test
@@ -264,14 +264,14 @@ public void buildTokenUrlSoftMtlsBound_mtls_transport_iam_enforcement() {
   }
 
   @Test
-  public void buildTokenUrlHardMtlsBound_always_enforced() {
+  public void buildTokenUrl_always_enforced() {
     ComputeEngineCredentials credentials =
         ComputeEngineCredentials.newBuilder()
             .setBindingEnforcement(ComputeEngineCredentials.BindingEnforcement.ON)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String tokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?binding-enforcement=on", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?binding-enforcement=on", tokenUrl);
   }
 
   @Test
@@ -281,9 +281,9 @@ public void buildTokenUrlHardMtlsBound_mtls_transport_always_enforced() {
             .setGoogleAuthTransport(ComputeEngineCredentials.GoogleAuthTransport.MTLS)
             .setBindingEnforcement(ComputeEngineCredentials.BindingEnforcement.ON)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String hardBoundTokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?transport=mtls&binding-enforcement=on", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?transport=mtls&binding-enforcement=on", hardBoundTokenUrl);
   }
 
   @Test
@@ -292,9 +292,9 @@ public void buildTokenUrlHardDirectPathBound_alts_transport() {
         ComputeEngineCredentials.newBuilder()
             .setGoogleAuthTransport(ComputeEngineCredentials.GoogleAuthTransport.ALTS)
             .build();
-    String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
+    String hardBoundTokenUrl = credentials.createTokenUrlWithScopes();
 
-    assertEquals(TOKEN_URL + "?transport=alts", softBoundTokenUrl);
+    assertEquals(TOKEN_URL + "?transport=alts", hardBoundTokenUrl);
   }
 
   @Test