Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add warnings to users about using credentials from external sources #1619

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jan 16, 2025

Context: b/389124064

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 16, 2025
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is also needed here:

public static ServiceAccountCredentials fromStream(InputStream credentialsStream)

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 17, 2025
@lqiu96 lqiu96 marked this pull request as ready for review January 21, 2025 16:52
@lqiu96 lqiu96 requested review from a team as code owners January 21, 2025 16:52
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lqiu96 lqiu96 dismissed sai-sunder-s’s stale review January 22, 2025 21:47

Review is outdated. Added only to fromStream() methods.

@lqiu96 lqiu96 merged commit 1529302 into main Jan 22, 2025
20 checks passed
@lqiu96 lqiu96 deleted the readme-warning branch January 22, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants