Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Ruby team to members for 2P reviews #1640

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

meltsufin
Copy link
Member

No description provided.

@meltsufin meltsufin requested review from a team as code owners January 30, 2025 01:02
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 30, 2025
@meltsufin meltsufin requested review from dazuma and chingor13 January 30, 2025 02:05
@dazuma
Copy link
Member

dazuma commented Jan 30, 2025

Can you explain this a little more to me? Does it mean I'm being added to the reviewer pool for this library? I don't think I'd be useful.

@meltsufin
Copy link
Member Author

Can you explain this a little more to me? Does it mean I'm being added to the reviewer pool for this library? I don't think I'd be useful.

This just identifies you as a Googler so that your PR authorship or review counts towards the requirement of two Googlers agreeing on a change.

@meltsufin meltsufin merged commit 5e2c00a into main Jan 31, 2025
18 checks passed
@meltsufin meltsufin deleted the ruby-members-json branch January 31, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants