-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow protobuf 6.x #13637
Merged
Merged
fix: Allow protobuf 6.x #13637
+122
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presubmit
This was fixed by 346097d |
vchudnov-g
reviewed
Mar 10, 2025
56340ed
to
62cf867
Compare
62cf867
to
79789f5
Compare
vchudnov-g
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! One non-trivial (but still minor) comment about avoiding the try
/catch
.
Co-authored-by: Victor Chudnovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply changes from googleapis/gapic-generator-python#2352 and googleapis/gapic-generator-python#2347 to 4 packages containing protobuf stubs which are not automatically generated using
gapic-generator-python
BEGIN_COMMIT_OVERRIDE
fix: Allow protobuf 6.x
fix: resolve issue where pre-release versions of dependencies are installed
END_COMMIT_OVERRIDE