fix: retry ExceptionHandler not retrying on IOException #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: xl
…le thrown IOExceptions
shollyman
reviewed
Mar 6, 2025
| } | ||
|
|
||
| @Test | ||
| public void testCreateJobFailureShouldRetry() { | ||
| when(bigqueryRpcMock.create(jobCapture.capture(), eq(EMPTY_RPC_OPTIONS))) | ||
| public void testCreateJobFailureShouldRetryExceptionHandlerExceptions() throws IOException { |
There was a problem hiding this comment.
Should we have similar testing for the TableDataWriteChannel that validates behavior for retryable IOException cases? That one's potentially more tricky as it is focused more on inline uploads rather than streaming inserts, despite the poorly chosen name.
There was a problem hiding this comment.
Good call out. TabelDataWriteChanel retry on SocketException which is not included in our BIGQUERY_EXCEPTION_HANDLER. I've added it to the general default retry behavior which is also used outside of TabelDataWriteChanel. I think this makes sense but we can move it into just have it within TabelDataWriteChanel if you think that is better.
Added retry tests to TableDataWriteChanelTest. PTAL.
whuffman36
reviewed
Mar 10, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
whuffman36
reviewed
Mar 10, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
whuffman36
reviewed
Mar 10, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
whuffman36
reviewed
Mar 10, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
whuffman36
reviewed
Mar 10, 2025
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
whuffman36
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an issue where the retry algorithm did not retrying based on the BIGQUERY_EXCEPTION_HANDLER configuration. This is caused by HttpBigQueryRpc translating IOExceptions into BigQueryException does not match the configurations set by BIGQUERY_EXCEPTION_HANDLER. To resolve this, we implement new internal methods (.*SkipExceptionTranslation) in HttpBigQueryRpc which do not translate the IOException. All retryable calls to HttpBigQueryRpc are updated to use these new methods.
In addition,
Fixes b/394167052 ☕️