[fontbe] remove workaround for old macOS bug with composites with all-zero deltas #1237
+12
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe let's hold this until fonttools actually releases the workaround removal (only merged on main yet). also, i'd like to conduct an experiment the all VFs on GF library to see how much bytes this will shave off from gvar |
cmyr
approved these changes
Feb 3, 2025
…-zero deltas Now that fonttools has also removed this old workaround, we shall remove it as well in fontc. See fonttools/fonttools#1788 Fixes #283
anthrotype
force-pushed
the
remove-composite-zero-deltas-workaround
branch
from
d711677 to
cd51b7a
Compare
anthrotype
force-pushed
the
remove-composite-zero-deltas-workaround
branch
from
ed74378 to
ef0ec76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that fonttools has also removed this old workaround, we shall remove it as well in fontc.
See fonttools/fonttools#1788
Fixes #283