Split Javascript and Python #2053
Open
+7,321
−3,090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncozens
force-pushed
the
js-split-2
branch
3 times, most recently
from
a090e3c to
a57e167
Compare
|
Aaand we're conflicted already. :-( |
git mv -k src/fontra/client/core/* src-js/fontra-core/src/
git mv -k src/fontra/client/web-components/* src-js/fontra-webcomponents/src
git mv -k src/fontra/client/* src-js/fontra-core/assets/
git mv -k src/fontra/views/applicationsettings/*js src-js/views-applicationsettings/src/
git mv -k src/fontra/views/applicationsettings/*html src-js/views-applicationsettings/
git mv -k src/fontra/views/editor/*js src-js/views-editor/src/
git mv -k src/fontra/views/editor/*html src-js/views-editor/
git mv -k src/fontra/views/editor/*css src-js/views-editor/assets/
git mv -k src/fontra/views/fontinfo/*js src-js/views-fontinfo/src/
git mv -k src/fontra/views/fontinfo/*html src-js/views-fontinfo/
git mv -k src/fontra/views/fontoverview/*js src-js/views-fontoverview/src/
git mv -k src/fontra/views/fontoverview/*html src-js/views-fontoverview
git mv -k src/fontra/views/fontoverview/*css src-js/views-fontoverview/assets/
simoncozens
force-pushed
the
js-split-2
branch
from
a57e167 to
3d82c3b
Compare
|
@justvanrossum Try now. |
justvanrossum
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Great! As far as I can see everything works now, and the code looks good, too.
I will merge as soon as googlefonts/fontra-rcjk#224 is functional, and Fontra Pak has been sorted out.
|
Fontra Pak: googlefonts/fontra-pak#156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1952.