Ensure language ID starts with language and script #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
reviewed
Nov 1, 2024
| @pytest.mark.parametrize("lang_code", LANGUAGES) | ||
| def test_id_well_formed(lang_code): | ||
| if lang_code in ["tw_akuapem_Latn"]: | ||
| pytest.xfail("Well we need to have a conversation about that") |
There was a problem hiding this comment.
Yeah. We don't really have a schema for dialects in the same way that we have a schema for regional variants. I need understand from @moyogo why we want Akuapem Twi to be this and not, say, just plain tw_Latn (I think it's the prestige dialect) - particularly since we don't have any other tw_Latns to distinguish this from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175 and catches similar issues.