feat: add syncs API in compass #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haveiss
requested changes
Nov 28, 2023
bsushmith
reviewed
Nov 28, 2023
haveiss
reviewed
Nov 28, 2023
bsushmith
reviewed
Nov 29, 2023
| } | ||
|
|
||
| message SyncAssetsResponse { | ||
| string job_id = 1; |
There was a problem hiding this comment.
do you also want to add a job status check api ? will it be in a separate PR ? @batrov
There was a problem hiding this comment.
I think we can consider that later, for now we will only throw status accepted after triggering this API
batrov
force-pushed
the
compass-syncs
branch
from
d27f456
to
34aa07a
Compare
haveiss
reviewed
Nov 29, 2023
batrov
force-pushed
the
compass-syncs
branch
2 times, most recently
from
5cc37f5
to
f862c95
Compare
batrov
force-pushed
the
compass-syncs
branch
from
f862c95
to
25893a7
Compare
haveiss
approved these changes
Nov 29, 2023
bsushmith
approved these changes
Nov 29, 2023
sumitaich1998
pushed a commit
that referenced
this pull request
Jan 31, 2024
* feat: add syncs API in compass * chore: change http method and params --------- Co-authored-by: Hermawan Wijaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: goto/compass#67