-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples and scripts to use DV Maven extension 1.21 and DV API #1121
Conversation
eda1879
to
6f630e4
Compare
6f630e4
to
dd7efe8
Compare
9efeaed
to
d47ea5e
Compare
Regarding the failing Maven Build Caching Sample: https://ge.solutions-team.gradle.com/c/n26q3qjmlrujs/ad4vg3vhutpw4/goal-inputs?cacheability=cacheable I've seen this The real question to me though is what about this change causes this to occur? My best guess is that it is the It isn't clear to me why this is the only case that would break. I think we really need an updated Build Validation Scripts that doesn't require this workaround to make the most sense of this. |
Signed-off-by: Nelson Osacky <[email protected]>
I think we should have updated samples as soon as we can. Given BVS are frozen, I see two ways forward,
I think we should go for 1, what do you think @erichaagdev @clayburn ? |
Option 1 sounds fine, let's just make sure we track it so it does not stay ignored forever. |
Here's a link to the internal issue to re-enable the workflow: https://github.com/gradle/ge/issues/34353 |
This also fixes the maven build caching samples, the maven data capturing samples, the maven rollout script, the creating a maven distribution training.
The build caching samples are not working due to what seems like a bug in the BVS.