Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In filter #74

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

In filter #74

wants to merge 5 commits into from

Conversation

mznet
Copy link

@mznet mznet commented Aug 9, 2018

Druid has various filters and in filter is one of them. Using in filters, template or variable separated by comma can be used as query parameter. The value is transformed to array.

I referred to In Filter from this document(http://druid.io/docs/latest/querying/filters.html).

screen shot 2018-08-09 at 4 59 01 pm

  • With in filter, template or variable can be used to query

screen shot 2018-08-09 at 4 58 50 pm

  • With in filter, value which are separated by comma can be used to query

@shcarrico
Copy link
Collaborator

Please squash this pull into a single commit, with a message in the format listed here

https://gist.github.com/brianclements/841ea7bffdb01346392c

@shcarrico shcarrico self-requested a review September 5, 2018 08:05
@mznet
Copy link
Author

mznet commented Sep 9, 2018

@shcarrico Thank you for your review. I just wonder why the commit message format should be applied? Other PR didn't be composed with the format.

@Gauravshah
Copy link
Collaborator

@shcarrico you should be able to squash all commits into one during the merge. There is a feature in github that would allow you to squash a PR. https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants