Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove filter with custom value #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShilpaSivanesan
Copy link

Adding "REMOVE_FILTER" as a custom value allows to disable the filter

For Example :

screen shot 2018-08-19 at 10 57 05 pm

In the above Image,
App "web" does not have any version listed in App Version filter. Choosing "All" will default give value as 0
, But applying this custom value eliminates being 0 for all and gives out the actual web count

@shcarrico
Copy link
Collaborator

I'm unclear why "All" should have a value at all. Shouldn't "All" remove the filter?

@shcarrico shcarrico self-requested a review September 5, 2018 08:03
@Gauravshah
Copy link
Collaborator

All is subjective from grafana perspective. All could mean all options listed or it could mean all of the data. grafana has left that to user's choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants