Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Headers when using gRPC #1702

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Set Headers when using gRPC #1702

merged 3 commits into from
Feb 26, 2025

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Feb 26, 2025

Headers from env vars were set when using OTEL HTTP but not for gRPC.
This PR addresses this issue.

Fixes #1701

@marctc marctc requested a review from a team as a code owner February 26, 2025 14:40
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (b91e8c2) to head (5a8bffa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/export/otel/common.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1702      +/-   ##
==========================================
+ Coverage   69.83%   69.88%   +0.05%     
==========================================
  Files         209      209              
  Lines       21051    21065      +14     
==========================================
+ Hits        14701    14722      +21     
+ Misses       5638     5629       -9     
- Partials      712      714       +2     
Flag Coverage Δ
integration-test 53.99% <33.33%> (-0.37%) ⬇️
k8s-integration-test 54.59% <0.00%> (+0.19%) ⬆️
oats-test 34.85% <0.00%> (-0.31%) ⬇️
unittests 46.24% <53.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added one minor comment. I think we should also do this for the metrics export, none of the exporters have the headers.

@marctc marctc merged commit 2ded441 into main Feb 26, 2025
13 checks passed
@marctc marctc deleted the fix_grpc_headers branch February 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers not set using environment variable when using gRPC
2 participants