Update GrpcInflightMethodLimiter to support interceptors #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds server interceptor support to the
GrpcInflightMethodLimiter
via aRPCCallProcessing
callback. This is in addition to the existing tap handle support viaRPCCallStarting
.Interceptors are needed for inflight limiting where we want request blocking to be able to happen, since tap handles are not meant to have any blocking occur. In particular, adaptive limiters will use tap handles for most rejection, but interceptors for any blocking of requests that might be needed since they'll generally keep concurrency limits low.
This will require downstream users of
GrpcInflightMethodLimiter
to implementRPCCallProcessing
, which can be a noop if it's not used:Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]