grpcclient.Config: add support for injecting middleware.ClusterUnaryClientInterceptor #657
+162
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/grpc-cluster-interceptor
branch
from
22fbe37 to
77cb229
Compare
…idation-label Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-interceptor
branch
2 times, most recently
from
28874eb to
bd20f7d
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-interceptor
branch
from
bd20f7d to
01e5b2c
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-interceptor
branch
from
e7a03e8 to
5e68124
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-interceptor
branch
from
5e68124 to
fc58c4c
Compare
colega
reviewed
Mar 10, 2025
|
|
||
| // RegisteredFlagsTracker is an interface that allows to extract RegisteredFlags. | ||
| type RegisteredFlagsTracker interface { | ||
| GetRegisteredFlags() RegisteredFlags |
There was a problem hiding this comment.
Idiomatic Go is to drop the Get prefix on the getters.
Suggested change
| GetRegisteredFlags() RegisteredFlags | |
| RegisteredFlags() RegisteredFlags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds an experimental configuration option
-cluster-validation-labeltogrpcclient.Config. The intended usage of this configuration is to set the cluster validation label of gRPC clients.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]