Add ability to enable metrics in Grafana #334
Draft
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(grafana): Add ability to enable Metrics in Grafana role. * Add default variables for the `[metrics]` section in `roles/grafana/defaults/main.yml`. * Add documentation for the new metrics settings in `roles/grafana/README.md`. * Add tests to verify the new metrics settings in `roles/grafana/molecule/alternative/tests/test_alternative.py` and `roles/grafana/molecule/default/tests/test_default.py`.
|
|
|
If this is purely configured via grafana.ini that can be set via grafana_ini then it's arguable out of scope for grafana ansible role. And should it be enabled by default without auth? It's up to grafana to set defaults when not configured I'd think. Provinding guidance and examples is great tho. And if possible it should be made clearer that any grafana.ini settings can be configured via grafana_ini variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[metrics]section inroles/grafana/defaults/main.yml.roles/grafana/README.md.roles/grafana/molecule/alternative/tests/test_alternative.pyandroles/grafana/molecule/default/tests/test_default.py.I'm not sure if the test changes are needed, please advise if I should remove them
Fixes #332