Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lambda-promtail, Added support for parsing s3 access logs #16663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwitrick
Copy link

@jwitrick jwitrick commented Mar 10, 2025

What this PR does / why we need it:

Currently the lambda promtail code does not support processing of s3 server access logs. This PR allows for processing of s3 server access log files (of type plaintext) and sending the parsed log entries to promtail/loki.

Please note, due to how the existing getLabels function is written the path format for the access logs has to be AWSLogs/s3AccessLogs/ if s3AccessLogs is omitted then the path will match more than 1 regex and cause unexpected failures.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jwitrick jwitrick requested a review from a team as a code owner March 10, 2025 14:07
@jwitrick jwitrick force-pushed the feat-add-support-for-s3-access-logs branch from 1029533 to f4ebf6a Compare March 10, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant