Skip to content

Commit

Permalink
mixin: add Federation-frontend dashboard (#10697)
Browse files Browse the repository at this point in the history
* Add FF WIP

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Fix query panels

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Allow running mixin-serve for different mixins

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Remove comments

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Add CHANGELOG.md entry

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
  • Loading branch information
dimitarvdimitrov authored and ying-jeanne committed Feb 20, 2025
1 parent 04eeae7 commit 33f92f5
Show file tree
Hide file tree
Showing 7 changed files with 1,832 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
* [ENHANCEMENT] Dashboards: 'Writes' dashboard: show write requests broken down by request type. #10599
* [ENHANCEMENT] Dashboards: clarify when query-frontend and query-scheduler dashboard panels are expected to show no data. #10624
* [ENHANCEMENT] Alerts: Add warning alert `DistributorGcUsesTooMuchCpu`. #10641
* [ENHANCEMENT] Dashboards: Add "Federation-frontend" dashboard for GEM. #10697
* [BUGFIX] Dashboards: fix how we switch between classic and native histograms. #10018
* [BUGFIX] Alerts: Ignore cache errors performing `delete` operations since these are expected to fail when keys don't exist. #10287
* [BUGFIX] Dashboards: fix "Mimir / Rollout Progress" latency comparison when gateway is enabled. #10495
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ JSONNET_FMT := jsonnetfmt

# path to the mimir-mixin
MIXIN_PATH := operations/mimir-mixin
MIXIN_OUT_PATH := operations/mimir-mixin-compiled
MIXIN_OUT_PATH ?= operations/mimir-mixin-compiled
MIXIN_OUT_PATH_SUFFIXES := "" "-baremetal" "-gem"

# path to the mimir jsonnet manifests
Expand Down Expand Up @@ -683,8 +683,8 @@ check-mixin-mimirtool-rules: build-mixin
go run ./cmd/mimirtool rules check --rule-dirs "$(MIXIN_OUT_PATH)$$suffix"; \
done

mixin-serve: ## Runs Grafana loading the mixin dashboards compiled at operations/mimir-mixin-compiled.
@./operations/mimir-mixin-tools/serve/run.sh
mixin-serve: ## Runs Grafana loading the mixin dashboards. Use MIXIN_OUT_PATH=operations/mimir-mixin-compiled-gem for GEM variant
@./operations/mimir-mixin-tools/serve/run.sh -p $(MIXIN_OUT_PATH)

mixin-screenshots: ## Generates mixin dashboards screenshots.
@find $(DOC_SOURCES_PATH)/manage/monitor-grafana-mimir/dashboards -name '*.png' -delete
Expand Down
Loading

0 comments on commit 33f92f5

Please sign in to comment.