handle nil io.ReadCloser

grafana · Feb 19, 2025 · b9d512c · b9d512c
1 parent af4d53e
commit b9d512c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/pkg/storegateway/indexheader/binary_reader.go b/pkg/storegateway/indexheader/binary_reader.go
@@ -117,8 +117,12 @@ func WriteBinary(ctx context.Context, bkt objstore.BucketReader, id ulid.ULID, f
 
 	merr := multierror.MultiError{}
 	defer func() {
-		merr.Add(errors.Wrapf(sym.Close(), "close symbol reader"))
-		merr.Add(errors.Wrapf(tbl.Close(), "close posting offsets reader"))
+		if sym != nil {
+			merr.Add(errors.Wrapf(sym.Close(), "close symbol reader"))
+		}
+		if tbl != nil {
+			merr.Add(errors.Wrapf(tbl.Close(), "close posting offsets reader"))
+		}
 	}()
 
 	// wait until both GetRange requets have completed before writing bytes