Skip to content

Commit

Permalink
Set distributor.remote-timeout=10s for rulers in jsonnet/helm (#7143)
Browse files Browse the repository at this point in the history
* Set distributor.remote-timeout to 10s for rulers

* Update CHANGELOG.md

* Update operations/helm/charts/mimir-distributed/CHANGELOG.md

Co-authored-by: Marco Pracucci <[email protected]>

* Add comment explaining distributor.remote-timeout=10s

* Set -distributor.remote-timeout directly in the ruler deployment args list

---------

Co-authored-by: Marco Pracucci <[email protected]>
  • Loading branch information
leizor and pracucci authored Jan 18, 2024
1 parent b6216b7 commit befb428
Show file tree
Hide file tree
Showing 66 changed files with 77 additions and 0 deletions.
1 change: 1 addition & 0 deletions operations/helm/charts/mimir-distributed/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Entries should include a reference to the Pull Request that introduced the chang
* `-store-gateway.sharding-ring.heartbeat-timeout` set to `4m`
* `-compactor.ring.heartbeat-period` set to `1m`
* `-compactor.ring.heartbeat-timeout` set to `4m`
* [CHANGE] Ruler: Set `-distributor.remote-timeout` to 10s in order to accommodate writing large rule results to the ingester. #7143
* [ENHANCEMENT] Add `jaegerReporterMaxQueueSize` Helm value for all components where configuring `JAEGER_REPORTER_MAX_QUEUE_SIZE` makes sense, and override the Jaeger client's default value of 100 for components expected to generate many trace spans. #7068 #7086
* [ENHANCEMENT] Rollout-operator: upgraded to v0.10.1. #7125
* [ENHANCEMENT] Query-frontend: configured `-shutdown-delay`, `-server.grpc.keepalive.max-connection-age` and termination grace period to reduce the likelihood of queries hitting terminated query-frontends. #7129
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
{{- if .Values.ingester.zoneAwareReplication.migration.enabled }}
{{- if not .Values.ingester.zoneAwareReplication.migration.writePath }}
- "-ingester.ring.zone-awareness-enabled=false"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:

- mountPath: /certs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ spec:
- "-target=ruler"
- "-config.expand-env=true"
- "-config.file=/etc/mimir/mimir.yaml"
- "-distributor.remote-timeout=10s"
volumeMounts:
- name: config
mountPath: /etc/mimir
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-all-components-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-autoscaling-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-consul-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1433,6 +1433,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1464,6 +1464,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down Expand Up @@ -2396,6 +2397,7 @@ spec:
- -distributor.health-check-ingesters=true
- -distributor.ingestion-burst-size=200000
- -distributor.ingestion-rate-limit=10000
- -distributor.remote-timeout=10s
- -ingester.max-global-metadata-per-metric=10
- -ingester.max-global-metadata-per-user=30000
- -ingester.max-global-series-per-user=150000
Expand Down Expand Up @@ -2588,6 +2590,7 @@ spec:
- -distributor.health-check-ingesters=true
- -distributor.ingestion-burst-size=200000
- -distributor.ingestion-rate-limit=10000
- -distributor.remote-timeout=10s
- -ingester.max-global-metadata-per-metric=10
- -ingester.max-global-metadata-per-user=30000
- -ingester.max-global-series-per-user=150000
Expand Down Expand Up @@ -2780,6 +2783,7 @@ spec:
- -distributor.health-check-ingesters=true
- -distributor.ingestion-burst-size=200000
- -distributor.ingestion-rate-limit=10000
- -distributor.remote-timeout=10s
- -ingester.max-global-metadata-per-metric=10
- -ingester.max-global-metadata-per-user=30000
- -ingester.max-global-series-per-user=150000
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-env-vars-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-helm-parity-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,7 @@ spec:
- -blocks-storage.gcs.bucket-name=example-blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.multi.primary=consul
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.multi.primary=consul
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.multi.primary=consul
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.consul.hostname=consul.default.svc.cluster.local.:8500
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.multi.primary=consul
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-memcached-mtls-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-tests/test-multi-zone-generated.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,7 @@ spec:
- -blocks-storage.gcs.bucket-name=blocks-bucket
- -common.storage.backend=gcs
- -distributor.health-check-ingesters=true
- -distributor.remote-timeout=10s
- -ingester.ring.heartbeat-timeout=10m
- -ingester.ring.prefix=
- -ingester.ring.replication-factor=3
Expand Down
Loading

0 comments on commit befb428

Please sign in to comment.