Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace exp/slices with slices from standard library #10255

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Juneezee
Copy link
Contributor

What this PR does

The experimental functions in golang.org/x/exp/slices are now available in the standard library in Go 1.21 (https://go.dev/doc/go1.21#slices).

Which issue(s) this PR fixes or relates to

Checklist

  • [N/A] Tests updated.
  • [N/A] Documentation added.
  • [N/A] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [N/A] about-versioning.md updated with experimental features.

The experimental functions in `golang.org/x/exp/slices` are now
available in the standard library in Go 1.21 [1].

[1]: https://go.dev/doc/go1.21#slices

Signed-off-by: Eng Zer Jun <[email protected]>
aknuds1
aknuds1 previously approved these changes Dec 16, 2024
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aknuds1 aknuds1 dismissed their stale review December 16, 2024 11:42

Linting fails.

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the lint failures?

@Juneezee Juneezee requested a review from aknuds1 December 16, 2024 11:56
@aknuds1
Copy link
Contributor

aknuds1 commented Dec 16, 2024

Thanks!

@aknuds1 aknuds1 merged commit a979e2b into grafana:main Dec 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants