Querier: pass query matchers to TimeRangeQueryable.IsApplicable function
#10256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
ortuman
force-pushed
the
ortuman/querier/pass-matchers-to-is-applicable-fn
branch
from
add0836 to
1dc8f06
Compare
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
ortuman
force-pushed
the
ortuman/querier/pass-matchers-to-is-applicable-fn
branch
from
76f79e2 to
da81c2c
Compare
ortuman
changed the title
TimeRangeQueryable.IsApplicable functionTimeRangeQueryable.IsApplicable function
ortuman
deleted the
ortuman/querier/pass-matchers-to-is-applicable-fn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
follow-up of #9712
This PR adds the necessary changes to propagate the passed matchers to the
TimeRangeQueryable.IsApplicablefunction, which can be useful for upstream projects by allowing a custom queryable to be applicable only for a specific queried metric.Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.