-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update make docs
procedure
#10539
Merged
Merged
Update make docs
procedure
#10539
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2971b8e
Update `make docs` procedure
grafanabot 0df7b17
Merge branch 'main' into update-make-docs
jdbaldry e2e7b56
Update `make docs` procedure
grafanabot 348c350
Merge branch 'main' into update-make-docs
jdbaldry 3106d2a
Update `make docs` procedure
grafanabot 8d9899f
Update `make docs` procedure
grafanabot 74dd9e0
Merge branch 'main' into update-make-docs
jdbaldry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Does make resolve
%
in the phony declarations? I thought the declaration is static sotarget/%
doesn't maketarget/foo
phony, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you're right, that's actually not gonna work if there's a
topic/task
file. I'll open a PR upstream to fix that behavior and you can expect an update to this PR in the next couple daysThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
8d9899f
(#10539)