Fix flaky TestConcurrentFetchers_fetchSingle
#10567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing because the control function was used up by the periodic fetch loop of the started `concurrentFetchers`. This meant that the test sometimes ran when we don't have a control function registered and didn't inject an error. At the same time the test cases didn't retain their control functions so that they don't interfere with each other. This change makes the test cases independent, so we can use `KeepControl`. Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
commented
Feb 3, 2025
dimitarvdimitrov
deleted the
dimitar/ingest/fix-flaky-concurrent-fetchers-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why it's falky
The test was failing because the control function was used up by the periodic fetch loop of the started
concurrentFetchers. This meant that the test sometimes ran when we don't have a control function registered and didn't inject an error.At the same time the test cases didn't retain their control functions so that they don't interfere with each other.
What this PR does
This change makes the test cases independent, so we can use
KeepControl.Which issue(s) this PR fixes or relates to
Fixes #9916
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.