Build both Mimir docs sources in deploy preview #10580
Conversation
jdbaldry
force-pushed
the
jdb/2025-02-build-both-mimir-docs
branch
2 times, most recently
from
5cbffff to
4b0b4db
Compare
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/2025-02-build-both-mimir-docs
branch
from
4b0b4db to
c100456
Compare
Signed-off-by: Jack Baldry <[email protected]> (cherry picked from commit d0c61ea) Signed-off-by: Jack Baldry <[email protected]>
|
Thanks for the reviews, a mimir maintainer can merge this whenever they want the feature |
| "relative_prefix": "/docs/mimir/v2.15.x/", | ||
| "repo": "mimir", | ||
| "source_directory": "docs/sources/mimir", | ||
| "website_directory": "content/docs/mimir/v2.15.x" |
There was a problem hiding this comment.
Does Mimir release shepherds need to keep these values in-sync with current active releases? If yes, can we add a note about that in the RELEASE.md.
There was a problem hiding this comment.
Yeah, I think so because I can't add steps in to the workflow because its using a reusable workflow rather than calling an action.
I went to update the RELEASE file but I wasn't sure where to put things.
I don't see anything about updating the variables in https://github.com/grafana/mimir/blob/jdb%2F2025-02-build-both-mimir-docs/docs/sources/helm-charts/mimir-distributed/_index.md?plain=1#L10-L12 which is an associated release task. Do you have any ideas where I should put it?
Signed-off-by: Jack Baldry [email protected]
What this PR does
This change to the workflow builds both the Mimir docs and the Mimir Helm chart docs in a single deploy preview and posts the links to both back on the PR.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.