Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace markblocks with rewritten mark-blocks #10597

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Replace markblocks with rewritten mark-blocks #10597

wants to merge 12 commits into from

Conversation

andyasp
Copy link
Contributor

@andyasp andyasp commented Feb 6, 2025 •
edited
Loading

What this PR does

Replaces markblocks with a rewritten version uncreatively named mark-blocks.

The motivation for this is that I'm in a situation (don't ask) that requires marking and then later unmarking a large number of blocks.

markblocks as written was limiting for this because:

  • it only supports adding marks, not removing them
  • it only supports blocks specified as an argument, which doesn't work for large lists
  • marking blocks can fail halfway (on the global marker) and then can't be retried without manual intervention
  • when a failure is encountered on a large number of blocks it would be nice to easily resume in a way that does not replicate work or require modifying the input

The rewrite addresses these points.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

💻 Deploy preview available: https://deploy-preview-mimir-10597-zb444pucvq-vp.a.run.app/docs/mimir/latest/

@andyasp andyasp marked this pull request as ready for review February 10, 2025 17:02
tacole02
tacole02 approved these changes Feb 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacole02 tacole02 tacole02 approved these changes

@wilfriedroset wilfriedroset Awaiting requested review from wilfriedroset wilfriedroset is a code owner

@vaxvms vaxvms Awaiting requested review from vaxvms vaxvms is a code owner

@bubu11e bubu11e Awaiting requested review from bubu11e bubu11e is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyasp @tacole02