'Reads' and 'Remote ruler reads' dashboards: add ingester and store-gateway query request panels for respective query path #10598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w data from all query paths, and add them to the Remote Ruler Reads dashboard too
|
There's quite a bit of jsonnet to interpret here. Could you please provide some screenshots of the changes to assist with reviewing? |
Sorry, took a screenshot and forgot to add it to the PR description 🤦 I've added this now. |
jhesketh
reviewed
Feb 7, 2025
jhesketh
approved these changes
Feb 7, 2025
| @@ -125,46 +125,9 @@ local filename = 'mimir-reads.json'; | |||
| querySchedulerJobName=$._config.job_names.query_scheduler, | |||
| querierJobName=$._config.job_names.querier, | |||
| queryRoutesRegex=$.queries.read_http_routes_regex, | |||
| queryPathDescription='main query path (ie. not the ruler query path, if enabled)', | |||
There was a problem hiding this comment.
Suggested change
| queryPathDescription='main query path (ie. not the ruler query path, if enabled)', | |
| queryPathDescription='main query path (excluding ruler query path, if enabled)', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes a number of changes to the 'Reads' and 'Remote ruler reads' dashboards:
This is what the 'Reads' dashboard looks like now (and the 'Remote ruler reads' dashboard is similar):
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.