Subquery Spin-Off: Prioritize query sharding #10621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we aggregate the results of a subquery, sharding is faster in some cases, slower in some. Overall, the impact of the feature seems to be near-zero. Since: - we're not gaining anything - subquery spin-off is the newer feature, and it would be preferrable not to introduce a regression on existing queries - subquery spin-off has an additional overhead of running a second query I think we can give query sharding the priority
colega
reviewed
Feb 10, 2025
Done!
🤦 I was sure I added a CHANGELOG for this, but seems I forgot. Added it now, with all three PRs listed |
tacole02
approved these changes
Feb 10, 2025
Co-authored-by: Taylor C <[email protected]>
charleskorn
approved these changes
Feb 11, 2025
Co-authored-by: Charles Korn <[email protected]>
julienduchesne
deleted the
julienduchesne/subquery-spin-off-prioritize-sharding
branch
julienduchesne
added a commit
that referenced
this pull request
Feb 11, 2025
* Subquery Spin-Off: Prioritize query sharding In cases where we aggregate the results of a subquery, sharding is faster in some cases, slower in some. Overall, the impact of the feature seems to be near-zero. Since: - we're not gaining anything - subquery spin-off is the newer feature, and it would be preferrable not to introduce a regression on existing queries - subquery spin-off has an additional overhead of running a second query I think we can give query sharding the priority * Add test + Add CHANGELOG * Update CHANGELOG.md Co-authored-by: Taylor C <[email protected]> * Update CHANGELOG.md Co-authored-by: Charles Korn <[email protected]> --------- Co-authored-by: Taylor C <[email protected]> Co-authored-by: Charles Korn <[email protected]> (cherry picked from commit 7338cd2) Co-authored-by: Julien Duchesne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we aggregate the results of a subquery, sharding is faster in some cases, slower in some. Overall, the impact of the feature seems to be near-zero.
Since:
I think we can give query sharding the priority
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.