Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update store-gateway heartbeat timeout to 10m #10634

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

56quarters
Copy link
Contributor

What this PR does

Change the ring heartbeat timeout for store-gateways to 10m in jsonnet and helm. This ensures that they do not leave the ring during rollouts causing block ownership to move around. We've been running with these settings at Grafana Labs for several weeks.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Change the ring heartbeat timeout for store-gateways to 10m in jsonnet
and helm. This ensures that they do not leave the ring during rollouts
causing block ownership to move around. We've been running with these
settings at Grafana Labs for several weeks.

Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters marked this pull request as ready for review February 12, 2025 17:37
@56quarters 56quarters requested a review from a team as a code owner February 12, 2025 17:37
@56quarters 56quarters merged commit 1e12972 into main Feb 13, 2025
30 checks passed
@56quarters 56quarters deleted the 56quarters/sg-ring-timeout branch February 13, 2025 19:00
ying-jeanne pushed a commit that referenced this pull request Feb 19, 2025
* chore: Update store-gateway heartbeat timeout to 10m

Change the ring heartbeat timeout for store-gateways to 10m in jsonnet
and helm. This ensures that they do not leave the ring during rollouts
causing block ownership to move around. We've been running with these
settings at Grafana Labs for several weeks.

Signed-off-by: Nick Pillitteri <[email protected]>

* Changelog

Signed-off-by: Nick Pillitteri <[email protected]>

---------

Signed-off-by: Nick Pillitteri <[email protected]>
ying-jeanne pushed a commit that referenced this pull request Feb 20, 2025
* chore: Update store-gateway heartbeat timeout to 10m

Change the ring heartbeat timeout for store-gateways to 10m in jsonnet
and helm. This ensures that they do not leave the ring during rollouts
causing block ownership to move around. We've been running with these
settings at Grafana Labs for several weeks.

Signed-off-by: Nick Pillitteri <[email protected]>

* Changelog

Signed-off-by: Nick Pillitteri <[email protected]>

---------

Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants