-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning alert for too high distributor GC CPU utilization #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbe90b1
to
5ebb476
Compare
💻 Deploy preview deleted. |
d88b61b
to
4b432f0
Compare
NickAnge
reviewed
Feb 13, 2025
...metamonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
Outdated
Show resolved
Hide resolved
4b432f0
to
0ae0973
Compare
tacole02
approved these changes
Feb 13, 2025
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Taylor C <[email protected]>
ee730d1
to
c53d7bf
Compare
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
pracucci
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed doing pair programming. LGTM!
pracucci
reviewed
Feb 14, 2025
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 19, 2025
* Enable three CPU runtime metrics * operations: Add warning alert for too high distributor GC CPU usage --------- Signed-off-by: Arve Knudsen <[email protected]> Co-authored-by: Taylor C <[email protected]>
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Enable three CPU runtime metrics * operations: Add warning alert for too high distributor GC CPU usage --------- Signed-off-by: Arve Knudsen <[email protected]> Co-authored-by: Taylor C <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-10641-to-r314 origin/r314
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1ce9dff5f306b906eff412bf9b5f62c6ae9dd102
# Push it to GitHub
git push --set-upstream origin backport-10641-to-r314
git switch main
# Remove the local backport branch
git branch -D backport-10641-to-r314 Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add a warning severity alert for too high distributor garbage collection CPU utilization. The motivation is to be alerted if
GOMEMLIMIT
causes distributors to garbage collect too often.Additionally, enable three CPU runtime metrics required by the alerts:
/cpu/classes/gc/total:cpu-seconds
/cpu/classes/total:cpu-seconds
/cpu/classes/idle:cpu-seconds
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.