Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove deprecated config: align_queries_with_step #10642

Closed
wants to merge 1 commit into from

Conversation

leehack
Copy link

@leehack leehack commented Feb 13, 2025

What this PR does

Remove deprecated config that was removed since 2.14.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@leehack leehack requested review from tacole02 and a team as code owners February 13, 2025 13:38
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@leehack
Copy link
Author

leehack commented Feb 13, 2025

For context: After updating Mimir to 2.15, our Mimir workloads entered a crashloop due to a misconfiguration. This was confusing as the latest official documentation still lists the problematic configuration parameter.

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR is valid. The setting you've mentioned, YAML limits.align_queries_with_step and CLI -query-frontend.align-queries-with-step are both still supported and not deprecated. The YAML configuration frontend.align_queries_with_step was removed in Mimir 2.14 and was removed from the docs. The documentation you are referencing is not that.

@leehack
Copy link
Author

leehack commented Feb 13, 2025

I don't think this PR is valid. The setting you've mentioned, YAML limits.align_queries_with_step and CLI -query-frontend.align-queries-with-step are both still supported and not deprecated. The YAML configuration frontend.align_queries_with_step was removed in Mimir 2.14 and was removed from the docs. The documentation you are referencing is not that.

Ah. You are right. Sorry for the confusion. Closing the PR.

@leehack leehack closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants