Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] helm: add service.extraPorts to all components #10659

Merged
merged 13 commits into from
Mar 7, 2025

Conversation

TheRealNoob
Copy link
Contributor

@TheRealNoob TheRealNoob commented Feb 14, 2025

What this PR does

In the Helm chart, add service.extraPorts to all components that allow defining extraContainers. The intention being that people may expose additional ports on the Pod, and that should be exposed from the Service as well.

I haven't bumped the chart version, could you tell me what it should be bumped to? I'm not familiar with the format being used.

Which issue(s) this PR fixes or relates to

Didn't open one

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@TheRealNoob TheRealNoob requested a review from a team as a code owner February 14, 2025 21:22
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025

CLA assistant check
All committers have signed the CLA.

@narqo
Copy link
Contributor

narqo commented Feb 18, 2025

Thank you for working on the PR. Before moving the changes further, could you provide more details about the problem you were solving

[..] The intention being that people may expose additional ports on the Pod

Is this a theoretical case? Or can you share a practical scenario where ports from mimir components were missing and needed to be exposed to the cluster?

@TheRealNoob
Copy link
Contributor Author

TheRealNoob commented Feb 18, 2025

@narqo Thank you for having a look. The use-case that I'm working on is exposing prometheus and alertmanager to the internet behind an oauth2 sidecar. I'm setting them up under new ingress objects so as to not interfere with the main ingress which I have using basicAuth authentication.

I saw in the chart that there are already comments in place on the alertmanager.extraContainers spec for exactly this kind of sidecar, in which case this PR is just an expansion of that intention.

Let me know if you need me to go into any more detail. In short, if someone adds an extraContainer that exposes a new port, there is a very high likelihood that they'll need to expose it on the SVC as well.

@TheRealNoob
Copy link
Contributor Author

I think the lint check is a false positive caused by the single quote in the word component's. Any preference on how you want to solve? I see other entries in the changelog with the same single-use single-quote so I'm guessing this is an ignored warning?

Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. The changes look good to me, I believe the markdown-lint's failure is indeed a false-positive. I can take care of it.

@narqo narqo enabled auto-merge (squash) March 6, 2025 08:28
@narqo
Copy link
Contributor

narqo commented Mar 6, 2025

@TheRealNoob the SLA signing job says

Mike Timmerman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

It seems that this comes after one of your commits that uses this author's name and the email. Could you either add the email to your github account, or update the changeset to use the git author, that signs the SLA. Sorry for extra bureaucracy.

auto-merge was automatically disabled March 6, 2025 20:06

Head branch was pushed to by a user without write access

@TheRealNoob
Copy link
Contributor Author

well that was fun. I was previously changing some settings on my gitconfig to make it easier to work with two accounts from one machine (work and personal) which led to mis-signed commits. And then the marvelous joys of learning rebase (again). Never fun, but hopefully one day I'll be able to do something without having to look it up :). Apologies for the troubles.

@narqo narqo enabled auto-merge (squash) March 7, 2025 08:07
@narqo narqo merged commit 42198d3 into grafana:main Mar 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants