Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golang versions (#10708) #10716

Closed
wants to merge 6 commits into from

Conversation

aldernero
Copy link
Contributor

  • chore: bump golang versions

  • Update build image version to pr10708-6841577474

backport #10708 to r330

* chore: bump golang versions

* Update build image version to pr10708-6841577474

---------

Co-authored-by: aldernero <[email protected]>
(cherry picked from commit 5506d2e)
Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr10716-6841577474. This can take up to 1 hour.

Copy link
Contributor

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr10716-f819d30595. This can take up to 1 hour.

Copy link
Contributor

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr10716-f819d30595 already exists.

Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Works for me. Although, do we really have to backport this to this weekly release?

GEM uses its own toolchain, and its weeklies have their own set of Go-version constraints. So this change shouldn't make any difference there (I could be wrong about that).

I'd maybe backported it to release-2.15, if we're aiming at shipping 2.15.1. But maybe this can be just a part of the future 2.16?

@aldernero aldernero closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants