-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alertmanager: Expermental pre-notification webhooks. #10718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea788a9
to
bbea9f7
Compare
💻 Deploy preview deleted. |
bbea9f7
to
2ab834b
Compare
2ab834b
to
6633b39
Compare
tacole02
approved these changes
Feb 23, 2025
alexander-akhmetov
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A question: do we want some default value for notify hook timeout instead of 0?
stevesg
commented
Feb 26, 2025
stevesg
added a commit
that referenced
this pull request
Feb 27, 2025
* Alertmanager: Expermental pre-notification webhooks. * Update timeout default and description * Apply rate limits before hooks (cherry picked from commit dc137af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an experimental feature where administrators can configure hooks to run before notifications are sent. This can be used for logging or auditing purposes, or for adding additional context to alert payloads. Everything here is subject to change.
Introduces a command line flag to enable and disable the code path entirely (
-alertmanager.notify-hooks-enabled
), and three -per-tenant overrides to configure the hook:alertmanager_notify_hook_url
: The URL of the service to call out to.alertmanager_notify_hook_receivers
: If blank, all notifications are passed to the hook, otherwise, only notifications are passed for receivers where the name is specified in this list.alertmanager_notify_hook_timeout
: Maximum time to wait for the hook to complete before performing the notification regardless. Note that failed hook invocations should never prevent notifications.If we find this feature valuable and pursue it further, considerations will be taken allow more configuration of the HTTP client (e.g. TLS, basic auth). For now, this is omitted.