Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: Remove depracated KEDA parameters #10737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Jsonnet: Remove depracated KEDA parameters #10737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions operations/mimir/autoscaling.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,6 @@
serverAddress: $._config.autoscaling_prometheus_url,
query: trigger.query,

// The metric name uniquely identifies a metric in the KEDA metrics server.
// This is deprecatd in KEDA 2.10, and is instead set to a default based on the trigger type (e.g. `s0-prometheus`).
// Instead we use the metric_name as the name for the trigger (above). This appears as the `scaler` label on `keda_scaler_metrics_value`.
metricName: trigger.metric_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we switch to name instead of metricName now? https://keda.sh/docs/2.16/reference/scaledobject-spec/#triggers


// The threshold value is set to the HPA's targetAverageValue. The number of desired replicas is computed
// by HPA as:
// desiredReplicas = ceil[currentReplicas * ( currentMetricValue / desiredMetricValue )]
Expand Down
Loading