ruler: add /ruler/tenants service API #10738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/ruler-api-tenants
branch
from
b58a13f to
15d9580
Compare
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/ruler-api-tenants
branch
from
15d9580 to
cd9853e
Compare
colega
reviewed
Feb 25, 2025
| for _, g := range rg { | ||
| groups = append(groups, ruleGroupData{ | ||
| Name: g.GetName(), | ||
| Namespace: g.GetNamespace(), |
There was a problem hiding this comment.
How about we include RuleCount: len(g.Rules) here as well?
There was a problem hiding this comment.
I actually wanted to do the same initially, but len(g.Rules) doesn't have any rules until we ask the Ruler to go to storage, and to populate them for every namespace and group — via the RuleStore.LoadRuleGroups — this is confusing, yes. I'd skip doing that (at least for now).
Signed-off-by: Vladimir Varankin <[email protected]>
Sure, good point. We seem to not see these service APIs as something we guarantee (at I haven't noticed any similar tests in other places), but I don't see why the behaviour around how limits work with this API shouldn't be covered. |
colega
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a new
/ruler/tenantsendpoint to list tenants, therulerservice discovered in its storage. The idea here is to provide an external operator-component a way to observe which tenants have rules, without asking Mimir to retrieve the actual rules.The API endpoint is complementary to the existing
/store-gateway/tenants,/compactor/tenants, and/ingesters/tenants.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.