distributor: Run ingestion limiter after custom push wrappers #10754
+113
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was chasing an issue where a tenant was limited on a 10k/s limit, with a ~200/s received rate. Turns out that the ingestion limit was applied and then custom push wrappers were removing timeseries and samples. The number of series recorded in the metrics was the one after custom push wrappers Ingestion rate limit should apply after all push wrappers, since its purpose is to limit what we send to ingesters With this bug, the `Mimir / Tenants` dashboard is also wrong because the limit is shown against the number of received samples
julienduchesne
force-pushed
the
julienduchesne/distributor-run-ingester-limit
branch
from
0e9e553 to
fd54d56
Compare
|
I don’t agree with the premise. The point of the limit is to protect distributors. |
|
Not related in this particular case, since the incoming rate was clearly over the limit, but since other people have erroneously picked up on this PR I will link it: (If the limit line was on the panel to the left, this confusion might be eased) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was chasing an issue where a tenant was limited on a 10k/s limit, with a ~200/s received rate.
Turns out that the ingestion limit was applied and then custom push wrappers were removing timeseries and samples. The number of series recorded in the metrics was the one after custom push wrappers
Ingestion rate limit should apply after all push wrappers, since its purpose is to limit what we send to ingesters
With this bug, the
Mimir / Tenantsdashboard is also wrong because the limit is shown against the number of received samples (see screenshot for example of that) and we have no way to alert when we're approaching limits since we would typically usecortex_distributor_received_samples_totalagainst the limit for thatChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.