Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade dskit, use LimitsMap from flagext #10768

Merged
merged 10 commits into from
Feb 28, 2025
Merged

Conversation

alexweav
Copy link
Contributor

@alexweav alexweav commented Feb 28, 2025

What this PR does

Upgrades dskit, bringing in these four commits: https://github.com/grafana/dskit/commits/main/?since=2025-02-27&until=2025-02-27

  • 3 commits from @duricanikolic regarding cluster request validation; adding new functionality and extending ClusterUnaryClientInterceptor which does not appear to be referenced in Mimir yet, so this seems safe.
  • 1 commit from @alexweav copying a utility from mimir to dskit
  • 1 commit from @56quarters, memcached perf improvement

I've completed the move of that utility here, by deleting LimitsMap from Mimir and switching to the dskit one. See grafana/dskit#651

Which issue(s) this PR fixes or relates to

n/a

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@alexweav alexweav changed the title chore: Upgrade dskit, use limits map from flagext chore: Upgrade dskit, use LimitsMap from flagext Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

💻 Deploy preview deleted.

@alexweav alexweav marked this pull request as ready for review February 28, 2025 18:01
@alexweav alexweav requested review from stevesg, grafanabot, a team and tacole02 as code owners February 28, 2025 18:01
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexweav alexweav merged commit 63c0cd2 into main Feb 28, 2025
30 checks passed
@alexweav alexweav deleted the alexweav/use-flagext-map branch February 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants