Add additional check on reactive limiter queue sizes #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhalterman
changed the title
jhalterman
force-pushed
the
reactive-limiter-queue-size
branch
from
685689a to
2ccb154
Compare
This change adds an additional check for reactive limiter queue sizes, that limits the amount of queueing in each limiter based on its settings, in addition to the prioritizer's threshold. This ensures that if the prioritizer hasn't calibrated recently, unexpected queueing does not occur.
jhalterman
force-pushed
the
reactive-limiter-queue-size
branch
from
2ccb154 to
1ffffc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This change improves on #10574 by adding an additional check for reactive limiter queue sizes that limits the amount of queueing in each limiter based on its individual settings. At present, rejections are based on the prioritizer's threshold, which is computed periodically and looks at queueing across limiters along with request priorities, but this doesn't prevent a large burst of requests from enqueueing before the next calibration takes place. This PR adds an additional guard against this.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.