-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop Nginx socket listening on IPv6 when IPv6 is disabled #10781
base: main
Are you sure you want to change the base?
Conversation
|
the change you're making is in the mimir/operations/helm/charts/mimir-distributed/values.yaml Lines 3657 to 3659 in a632b24
|
@dimitarvdimitrov, the Helm chart currently fails with the default
Would you prefer a |
Is it significantly different to migrate to the I would prefer not to reduce the friction around a deprecated component. That would force installs to migrate to the recommended deployment rather than fixing a problem early in the install and then having to do a migration in production systems. |
@@ -41,6 +41,7 @@ Entries should include a reference to the Pull Request that introduced the chang | |||
* [ENHANCEMENT] Set resources for smoke-test job. #10608 | |||
* [BUGFIX] Create proper in-cluster remote URLs when gateway and nginx are disabled. #10625 | |||
* [BUGFIX] Fix calculation of `mimir.siToBytes` and use floating point arithmetics. #10044 | |||
* [BUGFIX] Fix Nginx listening sockets when IPv6 is disabled on in Helm values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [BUGFIX] Fix Nginx listening sockets when IPv6 is disabled on in Helm values. | |
* [BUGFIX] Fix Nginx listening sockets when IPv6 is disabled in Helm values. |
What this PR does
Fixes an issue where the Nginx deployment would still bing to IPv6 even if we set
gateway.nginx.config.enableIPv6
to false.This causes the deployment to crash if IPv6 is disabled on the host.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.