Ingester client: configure cluster validation label via common configurations #10788
+698
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
requested review from
stevesg,
grafanabot,
a team and
tacole02
as code owners
|
💻 Deploy preview available: https://deploy-preview-mimir-10788-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
…urations Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
9dd57dd to
0161aef
Compare
colega
reviewed
Mar 4, 2025
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
ba77419 to
59daa07
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
4 times, most recently
from
eb90433 to
0b9248d
Compare
…s of querier worked Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
0b9248d to
4f13b8b
Compare
…ssesd Signed-off-by: Yuri Nikolic <[email protected]>
colega
reviewed
Mar 5, 2025
colega
reviewed
Mar 5, 2025
…validation.label Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
tacole02
approved these changes
Mar 6, 2025
| @@ -510,6 +510,11 @@ storage: | |||
| # system as object storage backend. | |||
| # The CLI flags prefix for this block configuration is: common.storage | |||
| [filesystem: <filesystem_storage_backend>] | |||
|
|
|||
| client_cluster_validation: | |||
| # (experimental) Optionally define client's cluster validation label. | |||
There was a problem hiding this comment.
Could we say a client's or the client's (depending on which makes more sense)?
There was a problem hiding this comment.
How about "Optionally define the cluster validation label to be sent by the client." or something like that, involving the verb "send", as it's unclear what the client (which client btw?) is going to do with the label?
There was a problem hiding this comment.
I have updated the description of this cli flag in grafana/dskit@fc58c4c
colega
reviewed
Mar 6, 2025
| @@ -510,6 +510,11 @@ storage: | |||
| # system as object storage backend. | |||
| # The CLI flags prefix for this block configuration is: common.storage | |||
| [filesystem: <filesystem_storage_backend>] | |||
|
|
|||
| client_cluster_validation: | |||
| # (experimental) Optionally define client's cluster validation label. | |||
There was a problem hiding this comment.
How about "Optionally define the cluster validation label to be sent by the client." or something like that, involving the verb "send", as it's unclear what the client (which client btw?) is going to do with the label?
Signed-off-by: Yuri Nikolic <[email protected]>
…munications Signed-off-by: Yuri Nikolic <[email protected]>
…ions Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
2 times, most recently
from
fb55ce6 to
17741f8
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
17741f8 to
80900b8
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
…ions Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
145b51d to
a1f6777
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/grpc-cluster-validation
branch
from
a1f6777 to
841c5e0
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR ugrades dskit to the latest version, which enriched
grpcclient.Configwith an additional experimental configuration options for setting the cluster validation label,-cluster-validation-label.Moreover, this PR introduces another experimental configuration option,
-common.cluster-validation-label, which is inherited by-ingester.client.cluster-validation-label, and used during the creation of ingester gRPC clients.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.