Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mimir-prometheus #10789

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Upgrade mimir-prometheus #10789

merged 1 commit into from
Mar 4, 2025

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Mar 4, 2025

What this PR does

This PR upgrades mimir-prometheus to include the changes from grafana/mimir-prometheus#833.

As mentioned in that PR:

This PR only includes a single upstream PR: prometheus/prometheus#15851.

The main potentially problematic change is the new default value of model.NameValidationScheme, which has switched to UTF8Validation. I believe this change is safe to bring into Mimir, as we already set model.NameValidationScheme to LegacyValidation in multiple places (1, 2, 3) that should cover all components that need to validate label names.

Full diff of prometheus/common changes: prometheus/common@v0.61.0...v0.62.0

Full diff of prometheus/client_golang changes: prometheus/client_golang@v1.20.5...v1.21.0-rc.0 (changelog)

There are no changes between v1.21.0-rc.0 and v1.21.0 of prometheus/client_golang.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review March 4, 2025 04:27
@charleskorn charleskorn requested review from stevesg, grafanabot and a team as code owners March 4, 2025 04:27
@charleskorn charleskorn merged commit 2c3759c into main Mar 4, 2025
28 checks passed
@charleskorn charleskorn deleted the charleskorn/upgrade-prometheus branch March 4, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants