Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor: make -compactor.max-lookback a per-tenant option #10794

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

dmwilson-grafana
Copy link
Contributor

What this PR does

Moves definition of -compactor.max-lookback from pkg/compactor/compactor.go to pkg/util/validation/limits.go and adds per-tenant overrides.

Which issue(s) this PR fixes or relates to

Follows: #10585

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

💻 Deploy preview deleted.

@dmwilson-grafana dmwilson-grafana marked this pull request as ready for review March 4, 2025 14:58
@dmwilson-grafana dmwilson-grafana requested review from tacole02 and a team as code owners March 4, 2025 14:58
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @dmwilson-grafana !

@dmwilson-grafana dmwilson-grafana force-pushed the dwilson/set-compactor-max-limits-override branch from f928c74 to a8e6280 Compare March 7, 2025 19:04
@56quarters 56quarters merged commit c7bd8bd into main Mar 7, 2025
30 checks passed
@56quarters 56quarters deleted the dwilson/set-compactor-max-limits-override branch March 7, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants