Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add back split and cache to range middlewares #10796

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Mar 4, 2025

It was removed here: #10742 by mistake

Also, change TestMiddlewaresConsistency so that we catch those

Checklist

  • Tests updated.
  • [N/A] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [N/A] about-versioning.md updated with experimental features.

It was removed here: #10742 by mistake

Also, change `TestMiddlewaresConsistency` so that we catch those
@julienduchesne julienduchesne requested a review from a team as a code owner March 4, 2025 15:51
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick fix 🔥

@julienduchesne julienduchesne enabled auto-merge (squash) March 4, 2025 16:03
@julienduchesne julienduchesne merged commit e21e9f5 into main Mar 4, 2025
28 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/add-back-split-and-cache branch March 4, 2025 16:16
@grafana grafana deleted a comment from grafanabot Mar 4, 2025
@grafana grafana deleted a comment from grafanabot Mar 4, 2025
julienduchesne added a commit that referenced this pull request Mar 4, 2025
)

* frontend: Add back split and cache to range middlewares
It was removed here: #10742 by mistake

Also, change `TestMiddlewaresConsistency` so that we catch those

* Add CHANGELOG

(cherry picked from commit e21e9f5)

Co-authored-by: Julien Duchesne <[email protected]>
julienduchesne added a commit that referenced this pull request Mar 4, 2025
This tests two aspects of the split and cache feature:
1. We can go above the partial query length (because queries are split)
2. The query is split into multiple 24h queries

This is in response to #10796
julienduchesne added a commit that referenced this pull request Mar 4, 2025
This tests two aspects of the split and cache feature:
1. We can go above the partial query length (because queries are split)
2. The query is split into multiple 24h queries

This is in response to #10796
julienduchesne added a commit that referenced this pull request Mar 4, 2025
* frontend: Add integration test for split and cache middleware
This tests two aspects of the split and cache feature:
1. We can go above the partial query length (because queries are split)
2. The query is split into multiple 24h queries

This is in response to #10796

* Update integration/query_frontend_test.go

Co-authored-by: Dimitar Dimitrov <[email protected]>

---------

Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants