-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add back split and cache to range middlewares #10796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removed here: #10742 by mistake Also, change `TestMiddlewaresConsistency` so that we catch those
narqo
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a quick fix 🔥
julienduchesne
added a commit
that referenced
this pull request
Mar 4, 2025
) * frontend: Add back split and cache to range middlewares It was removed here: #10742 by mistake Also, change `TestMiddlewaresConsistency` so that we catch those * Add CHANGELOG (cherry picked from commit e21e9f5) Co-authored-by: Julien Duchesne <[email protected]>
julienduchesne
added a commit
that referenced
this pull request
Mar 4, 2025
This tests two aspects of the split and cache feature: 1. We can go above the partial query length (because queries are split) 2. The query is split into multiple 24h queries This is in response to #10796
1 task
julienduchesne
added a commit
that referenced
this pull request
Mar 4, 2025
This tests two aspects of the split and cache feature: 1. We can go above the partial query length (because queries are split) 2. The query is split into multiple 24h queries This is in response to #10796
julienduchesne
added a commit
that referenced
this pull request
Mar 4, 2025
* frontend: Add integration test for split and cache middleware This tests two aspects of the split and cache feature: 1. We can go above the partial query length (because queries are split) 2. The query is split into multiple 24h queries This is in response to #10796 * Update integration/query_frontend_test.go Co-authored-by: Dimitar Dimitrov <[email protected]> --------- Co-authored-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed here: #10742 by mistake
Also, change
TestMiddlewaresConsistency
so that we catch thoseChecklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.