Update grafanabot_reviewer.yml to use app token #10809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
approved these changes
Mar 5, 2025
|
This PR from grafanabot requires manual review. |
|
We can see from that message and https://github.com/grafana/mimir/actions/runs/13674321077/job/38231333682 that the workflow still works. |
narqo
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
I think, it may not work in practice — it doesn't work in the main branch — due to the author of the PR and reviewer cannot be the same (providing the mimir-github-bot:app_id belongs to grafanabot).
But this is not the problem of the change, let's finish getting rig of PAT's first, and get to fixing what's been already broken after 🔥
Update I think, the GitHub app will use the mimir-github-bot[bot] user. So we should be good. I.e. the app should be able to approve the grafanabot's PRs now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://github.com/grafana/deployment_tools/tree/master/docs/platform/continuous-integration#avoid-pull_request_target the workflow had to be changed from
on: pull_request_targettoon: pull_request. However that is fine as Grot PRs are created in the upstream repository thus that only makes the workflow safer!