Revert "Fix UTF-8 not allowed in Equal field for inhibition rules" #10813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
requested review from
grafanabot,
a team and
stevesg
as code owners
titolins
approved these changes
Mar 5, 2025
56quarters
approved these changes
Mar 5, 2025
grobinson-grafana
deleted the
revert-10780-grobinson/fix-utf8-not-allowed-in-equals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10780.
I found a subtle bug with this that can, in certain situations, cause the
Equalsfield to be lost when encoding an inhibition rule usingMarshalJSON. I want to revert it for now, rework the fix upstream, and then bring it back at a later time when I'm confident it's 100% right.You can read more about it here prometheus/alertmanager#4292.