Return context.Cause(ctx) as error so we can use custom timeout errors #10815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
force-pushed
the
zenador/qry-mw-limits-err
branch
from
bad130c to
c64fbf4
Compare
charleskorn
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
To use https://pkg.go.dev/context#WithTimeoutCause , we need to return the cause as error, which is the normal behaviour, except that when we use https://github.com/golang/sync/blob/master/semaphore/semaphore.go#L49 in this code, it does not use the cause as error. To fix that, we check the error returned from there and replace it with the cause if relevant. Without this change, using
WithTimeoutCausehas no effect when callingDoonlimitedParallelismRoundTripper.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.Minor change which by itself should not result in any user-facing changes, but this makes other changes possible.